London | ITP-May-2025 | Surafel Workneh | Structuring and testing data | Coursework/sprint 1 #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnment sprint -1 of 1-count.js
…m number generation in sprint -1 of 4-random.js
…'let' in sprint -1 of 1.js
…licing in sprint -1 of 3.js
…ons in sprint -1 of 4.js
…reassignment in percentage change calculation
…sprint -1 of 2-time-format.js
and describe the purpose in sprint -1 of 3-to-pounds.js
… sprint -1 of chrome.md
SuWebOnes
changed the title
SuWebOnes
changed the title
SuWebOnes
changed the title
cjyuan
added
Review in progress
cjyuan
reviewed
Jul 17, 2025
Comment on lines
+20
to
+24
| filePath | ||
| .slice(lastSlashIndex + 1) | ||
| .split(".") | ||
| .pop(); |
There was a problem hiding this comment.
What are these code for? They are not doing anything.
| .padStart(2, "0")}`; | ||
| } | ||
| console.log(convertTo12HourClockTime(twentyFourHourClockTime)); // Output: "08:53 PM" |
There was a problem hiding this comment.
Nice implementation! I don't think this statement outputs exactly "08:53 PM".
| // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem? | ||
| // There are no errors in the code. The code runs successfully and calculates the percentage change in car price without any issues. |
There was a problem hiding this comment.
You probably have fixed the error before answering question (b)
| // 1. const penceString = "399p": initialize a string variable with the value "399p" | ||
| //2. Removes the trailing "p" from the string: and result will be 399 | ||
| //3. Ensures the number has at least 3 digits by padding from the left with zeros: like 000 | ||
| //4. Extracts the pound portion: "3" |
There was a problem hiding this comment.
Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") (line 16) from the code?
In other words, do we really need .padEnd(2, "0") in this script?
| What is the return value of `prompt`? | ||
| surafel |
There was a problem hiding this comment.
I think the question is asking, in general, what does prompt() return when a user clicks "OK" and when a user clicks "Cancel".
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
[x] I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
[x] I have tested my changes
[x] My changes follow the style guide
[x] My changes meet the requirements of this task
Changelist
Briefly explain my PR.
Function Parameter and Return Handling
String Manipulation and Formatting
Time Conversion Logic
Testing and Debugging
Questions
Ask any questions you have for your reviewer.